Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Feature/sup 3127 marathonmatch details link #799

Merged
merged 7 commits into from
Jun 27, 2016

Conversation

vikasrohit
Copy link
Contributor

Fixed Submit link for marathon match
Fixed details link for active marathon match, it now leads user to problem statement page

vikasrohit added 6 commits April 19, 2016 12:49
… challenge page and submissions)

-- rough draft for the fix.
* dev: (65 commits)
  Trigger to pick up new member search updates
  Fix error message
  Add overrides to not inherit old style guide in member search
  Add logging if file is not the correct format for the field
  Remove TTL
  Test file extension and mime types and add tests
  AS#111987698191439, Modify logo for Dashboard TCO banner
  Trigger travis to pick up url encoding changes
  Encode search term
  Trigger travis build for member search updates
  Update to remove
  Remove Chrome=1, which is obsolete
  Fix typo
  AS#111130683709862, Topcoder Team Live banner (for Friday broadcast)
  Add back accidentally deleted line
  Fix orderBy error
  Remove debugger
  Fix typo
  Log errors to new relic
  Trigger travis build for default avatars
  ...
* dev: (34 commits)
  Remove only from tests
  Add new links for help.topcoder.com
  adding host to npm start
  AS#121262308049584, Reorder newsletter options and add "General Newsletter"
  AS#121262308049598, Change newsletter default
  AS#121262308049576, Copy changes
  AS#121262308049576, Copy changes
  Revert test
  Experiment with different cache setting
  AS#118090147171050, Email settings tab UI
  AS#118090147171048, Mail chimp Integration
  AS#118090147171050, Email settings tab UI
  AS#118090147171050, Email settings tab UI
  AS#118090147171050, Email settings tab UI
  Fix plural
  April members of the month
  AS#118090147171048, Mail chimp Integration
  AS#118090147171048, Mail chimp Integration
  AS#118090147171048, Mail chimp Integration
  AS#118090147171048, Mail chimp Integration
  ...
… challenge page and submissions) (Front end)
* dev: (121 commits)
  AS#145923029536767, Expand submission comment box to allow 1,000 characters -- Upgraded the limit for comments box
  AS#145923029536741, Filestack: restyle interface -- implemented suggested design.
  fixing linting errors
  AS#145319139176894, Submissions: File picker not working on dev -- Fixed minor styling
  AS#145319139176894, Submissions: File picker not working on dev -- Fixed file picker loading
  Revert "AS#145319139176894, Submissions: File picker not working on dev"
  AS#145319139176894, Submissions: File picker not working on dev
  Updated QA AWS secrets
  fix badge position problem
  updating images to centralize crowd for good badge in UI
  adding space on the earned on date of badges tooltip
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  Updated QA AWS secrets
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  AS#100297043256582, Move all login to link of Members to accounts.topcoder.com
  support crowd for good badge
  ...
… challenge page and submissions) (Front end)

-- Adapted code for handling the singular values instead of array of values for componentId and problemId fields as per discussion in asana task.
@@ -54,6 +64,8 @@ import angular from 'angular'
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#submissions', data)
case 'registrants':
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#viewRegistrant', data)
case 'submit':// TODO use details link for submit, we can replace it with new submission page url
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}', data)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthshah @fnisen @ajefts fyi, when we have single link for both design and development challenges for the new submission page, we can replace the details link with the submission link.

… challenge page and submissions) (Front end)

-- Fixed unit tests
@vikasrohit vikasrohit merged commit 2e78393 into dev Jun 27, 2016
@vikasrohit vikasrohit deleted the feature/sup-3127-marathonmatch-details-link branch June 27, 2016 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant